eliminated a lot of hints and warnings

[lcore.git] / lsocket.pas

diff --git a/lsocket.pas b/lsocket.pas
index bcff6436d3fc92511cd33d6934f9c07e6f884345..642ec9a0cfe4c80e339ad34993d9969b5b5f8e10 100755 (executable)
--- a/lsocket.pas
+++ b/lsocket.pas
@@ -134,6 +134,15 @@ type
 \r
       //this one has to be kept public for now because lcorewsaasyncselect calls it\r
       procedure connectionfailedhandler(error:word);\r
 \r
       //this one has to be kept public for now because lcorewsaasyncselect calls it\r
       procedure connectionfailedhandler(error:word);\r

+\r
+      {public in tlasio, and can't be private in both places, so should be public here. \r
+      fixes delphi warning --beware}\r
+      {$ifdef win32}\r
+        procedure myfdclose(fd : integer); override;\r
+        function myfdwrite(fd: LongInt;const buf;size: LongInt):LongInt; override;\r
+        function myfdread(fd: LongInt;var buf;size: LongInt):LongInt; override;\r
+      {$endif}\r
+\r

     private\r
       {$ifdef ipv6}\r
         isv6socket : boolean; //identifies if the socket is v6, set by bindsocket\r
     private\r
       {$ifdef ipv6}\r
         isv6socket : boolean; //identifies if the socket is v6, set by bindsocket\r


@@ -142,11 +151,6 @@ type
 \r
       procedure connecttimeouthandler(sender:tobject);\r
       procedure connectsuccesshandler;\r
 \r
       procedure connecttimeouthandler(sender:tobject);\r
       procedure connectsuccesshandler;\r

-      {$ifdef win32}\r
-        procedure myfdclose(fd : integer); override;\r
-        function myfdwrite(fd: LongInt;const buf;size: LongInt):LongInt; override;\r
-        function myfdread(fd: LongInt;var buf;size: LongInt):LongInt; override;\r
-      {$endif}\r

     end;\r
     tsocket=longint; // for compatibility with twsocket\r
 \r
     end;\r
     tsocket=longint; // for compatibility with twsocket\r
 \r


@@ -284,9 +288,6 @@ end;
 \r
 \r
 procedure tlsocket.connect;\r
 \r
 \r
 procedure tlsocket.connect;\r

-var\r
-  a:integer;\r
-  ip:tbinip;\r

 begin\r
   if state <> wsclosed then close;\r
   //prevtime := 0;\r
 begin\r
   if state <> wsclosed then close;\r
   //prevtime := 0;\r


@@ -345,7 +346,6 @@ end;
 \r
 procedure tlsocket.bindsocket;\r
 var\r
 \r
 procedure tlsocket.bindsocket;\r
 var\r

-  a:integer;\r

   inAddrtemp:TInetSockAddrV;\r
   inAddrtempx:{$ifdef win32}winsock.TSockaddr{$else}TInetSockAddrV{$endif} absolute inaddrtemp;\r
   inaddrtempsize:integer;\r
   inAddrtemp:TInetSockAddrV;\r
   inAddrtempx:{$ifdef win32}winsock.TSockaddr{$else}TInetSockAddrV{$endif} absolute inaddrtemp;\r
   inaddrtempsize:integer;\r


@@ -380,7 +380,9 @@ end;
 \r
 procedure tlsocket.listen;\r
 var\r
 \r
 procedure tlsocket.listen;\r
 var\r

+  {$ifndef win32}\r

   yes,no:longint;\r
   yes,no:longint;\r

+  {$endif}\r

   socktype:integer;\r
   biniptemp:tbinip;\r
   origaddr:thostname;\r
   socktype:integer;\r
   biniptemp:tbinip;\r
   origaddr:thostname;\r


@@ -427,10 +429,11 @@ begin
   state := wsclosed; // then set this back as it was an undesired side effect of dup\r
 \r
   try\r
   state := wsclosed; // then set this back as it was an undesired side effect of dup\r
 \r
   try\r

-    yes := $01010101;  {Copied this from existing code. Value is empiric,\r
-                    but works. (yes=true<>0) }\r
-    no := 0;\r

     {$ifndef win32}\r
     {$ifndef win32}\r

+      yes := $01010101;  {Copied this from existing code. Value is empiric,\r
+                    but works. (yes=true<>0) }\r
+      no := 0;\r
+\r

       if SetSocketOptions(fdhandlein, SOL_SOCKET, SO_REUSEADDR,yes,sizeof(yes))=-1 then begin\r
         raise ESocketException.create('unable to set SO_REUSEADDR socket option');\r
       end;\r
       if SetSocketOptions(fdhandlein, SOL_SOCKET, SO_REUSEADDR,yes,sizeof(yes))=-1 then begin\r
         raise ESocketException.create('unable to set SO_REUSEADDR socket option');\r
       end;\r


@@ -552,7 +555,7 @@ begin
   if result > absoloutemaxs then begin\r
     myfdclose(result);\r
     a := result;\r
   if result > absoloutemaxs then begin\r
     myfdclose(result);\r
     a := result;\r

-    result := -1;\r
+{    result := -1;}\r

     raise esocketexception.create('file discriptor out of range: '+inttostr(a));\r
   end;\r
 end;\r
     raise esocketexception.create('file discriptor out of range: '+inttostr(a));\r
   end;\r
 end;\r